fix: concurrent SlugifyName access (#18369)
Fixes 18369
Checklist:
- [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [x] The title of the PR states what changed and the related issues number (used for the release note).
- [x] The title of the PR conforms to the Toolchain Guide
- [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [x] Does this PR require documentation updates?
- [x] I've updated documentation as required by this PR.
- [x] I have signed off all my commits as required by DCO
- [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [x] My build is green (troubleshooting builds).
- [ ] My new feature complies with the feature status guidelines.
- [x] I have added a brief description of why this PR is necessary and/or what this PR solves.
- [x] Optional. My organization is added to USERS.md.
- [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 45.68%. Comparing base (
8776cc1) to head (7ffc97c). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #18370 +/- ##
=======================================
Coverage 45.68% 45.68%
=======================================
Files 353 353
Lines 46965 46967 +2
=======================================
+ Hits 21454 21456 +2
Misses 22772 22772
Partials 2739 2739
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ideally, this simple logic should not require being gated by a Mutex. That being said, I doubt we will be able to update the underlying library. Two PRs have been stale for at least three years.
- https://github.com/gosimple/slug/pull/51
- https://github.com/gosimple/slug/pull/41
If we are not comfortable using a Mutex we should probably update the documentation indicating Slugify is not multi-thread safe.