argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

otelgrpc package should use interceptors in favor of stats handlers

Open 34fathombelow opened this issue 1 year ago • 2 comments

Summary

Otelgrpc dependency (go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc) >= v0.46.0 has deprecated the use of StreamServerInterceptor, UnaryServerInterceptor, and StreamClientInterceptor. Migrating to stats handlers should be performed in a future release of Argo CD to guarantee backwards compatability.

  • https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4534

34fathombelow avatar May 16 '24 20:05 34fathombelow

@34fathombelow

I'm a new contributor. If this is not too difficult, could you assign it to me?

Jack-R-lantern avatar May 17 '24 15:05 Jack-R-lantern

@Jack-R-lantern feel free to take this task - this has been worked on in #17790, but is currently failing the E2E tests...

blakepettersson avatar May 20 '24 08:05 blakepettersson