argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

argocd events don't show app sync revision for multi-source apps

Open gdsoumya opened this issue 9 months ago • 1 comments

Describe the bug

When using multi source apps, the k8s event logs do not show the commit revision being synced to in the event message. Shows up as Initiated automated sync to ''

Possible issue in this part of the code which only considers desiredCommitSHA and not desiredCommitSHAsMS.

To Reproduce

  • Create a multi-source app, or even a single source app but use the sources field to declare the source.
  • Enable auto sync for the app
  • When the app auto syncs to a new revision, you should see k8s events with message Initiated automated sync to '' which is missing the revision hash.

Expected behavior

The sync revision hash should show up in the argocd events.

Version

v2.10.6

gdsoumya avatar May 10 '24 17:05 gdsoumya

Hi @gdsoumya. I would like to work on this.

How do you want the format to be when it is multi source app? Would it be okay to just join desiredCommitSHAsMS with , ?

onee-only avatar May 13 '24 00:05 onee-only

@onee-only yes comma separated values should be fine

gdsoumya avatar May 13 '24 05:05 gdsoumya