argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

Published 20 hours ago • verified publisher icon argoproj

feat: Timestamp for Health Status (#16972)

Open mkieweg opened this issue 1 year ago • 2 comments

This PR contains an implementation of the enhancement proposal https://github.com/argoproj/argo-cd/issues/16972 Closes [16972]

Checklist:

  • [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [x] The title of the PR states what changed and the related issues number (used for the release note).
  • [x] The title of the PR conforms to the Toolchain Guide
  • [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have signed off all my commits as required by DCO
  • [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).
  • [ ] My new feature complies with the feature status guidelines.
  • [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

mkieweg avatar Feb 21 '24 12:02 mkieweg

Hi @mkieweg, thanks for the PR. Is it ready for review?

Additionally, I was thinking would it might make sense to change the new field name from timestamp to lastTransitionTime to align with naming convention. I've noticed that both Applications and Applicationsets use lastTransitionTime in their status. What are your thoughts on this?

svghadi avatar May 06 '24 02:05 svghadi

Hey @svghadi, I was running into some issues with setting up the test dev environment locally and then had to pause the work due to shifting priorities. I'm planning to revise the current state and get my working branch on par with main this week.

Changing the name to adhere to existing conventions sounds like a good idea to me.

mkieweg avatar May 06 '24 15:05 mkieweg

Closed in favour of https://github.com/argoproj/argo-cd/pull/18660

mkieweg avatar Jun 14 '24 10:06 mkieweg