argo-cd
argo-cd copied to clipboard
feat(Prometheus): New metric: `build_info`
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [x] The title of the PR states what changed and the related issues number (used for the release note).
- [x] The title of the PR conforms to the Toolchain Guide
- [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [ ] Does this PR require documentation updates?
- [ ] I've updated documentation as required by this PR.
- [x] I have signed off all my commits as required by DCO
- [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [ ] My build is green (troubleshooting builds).
- [ ] My new feature complies with the feature status guidelines.
- [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
- [ ] Optional. My organization is added to USERS.md.
- [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 45.69%. Comparing base (
600737a) to head (477fd38). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #17186 +/- ##
==========================================
+ Coverage 45.68% 45.69% +0.01%
==========================================
Files 353 353
Lines 46965 46970 +5
==========================================
+ Hits 21454 21461 +7
+ Misses 22772 22771 -1
+ Partials 2739 2738 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM, maybe we should cover it with unit test though