argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

feat: adding option to specify an aws profile to use by the argocd-se…

Open igaskin opened this issue 1 year ago • 1 comments

…rver when adding a EKS cluster

useful for argocd-servers which are not running in AWS and want to add multiple EKS clusters using separate keys instead of assuming roles

#16766

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] The title of the PR conforms to the Toolchain Guide
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).
  • [ ] My new feature complies with the feature status guidelines.
  • [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

igaskin avatar Jan 06 '24 00:01 igaskin

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (54f1572) 49.48% compared to head (4d3fd8e) 49.47%.

Files Patch % Lines
cmd/argocd-k8s-auth/commands/aws.go 22.22% 7 Missing :warning:
pkg/apis/application/v1alpha1/types.go 0.00% 3 Missing :warning:
cmd/argocd/commands/admin/cluster.go 0.00% 1 Missing :warning:
cmd/argocd/commands/cluster.go 0.00% 1 Missing :warning:
cmd/util/cluster.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16767      +/-   ##
==========================================
- Coverage   49.48%   49.47%   -0.02%     
==========================================
  Files         271      271              
  Lines       47837    47847      +10     
==========================================
  Hits        23671    23671              
- Misses      21824    21834      +10     
  Partials     2342     2342              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 06 '24 01:01 codecov[bot]

@gdsoumya what are your thoughts on getting this merged to be part of the next 2.10.0 RC?

igaskin avatar Jan 11 '24 21:01 igaskin

I will let @crenshaw-dev decide on whether it can make it to the 2.10 rc

gdsoumya avatar Jan 12 '24 08:01 gdsoumya