argo-cd
argo-cd copied to clipboard
docs(proposal): support for post renderers
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [x] The title of the PR states what changed and the related issues number (used for the release note).
- [x] The title of the PR conforms to the Toolchain Guide
- [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [ ] Does this PR require documentation updates?
- [ ] I've updated documentation as required by this PR.
- [x] I have signed off all my commits as required by DCO
- [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [ ] My build is green (troubleshooting builds).
- [ ] My new feature complies with the feature status guidelines.
- [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
- [ ] Optional. My organization is added to USERS.md.
- [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
fixes
- https://github.com/argoproj/argo-cd/issues/3698
- https://github.com/argoproj/argo-cd/issues/7623
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 49.48%. Comparing base (
f87897c
) to head (e8d3bbc
). Report is 416 commits behind head on master.
:exclamation: Current head e8d3bbc differs from pull request most recent head d532fd7
Please upload reports for the commit d532fd7 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #16749 +/- ##
==========================================
- Coverage 49.73% 49.48% -0.25%
==========================================
Files 274 271 -3
Lines 48948 47728 -1220
==========================================
- Hits 24343 23620 -723
+ Misses 22230 21773 -457
+ Partials 2375 2335 -40
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have the POC on my fork: https://github.com/surajnarwade/argo-cd/compare/5bb7cd9b09f912cdffcb5db49386e1d91137a7e6...a399863e28c5296da8d2f3cae6bbd457195cf3bb for the same.
Heyo, any ETA on when you may get the feature in? I need to use a private helm chart and customize it which is s a LOT more painful than I expected and my options are either to hack it with Kustomize (i.e. this issue) and a Plugin, else if this feature is very soon going to be released I would just use this :)
@crenshaw-dev Is there anything more we need to do here, or can this proposal be accepted?
@crenshaw-dev Is there anything more we need in this proposal, can you review again please, TIA 🙏