argo-cd
argo-cd copied to clipboard
feat: wait until resources are deleted #6085
Closes: #6085
Adds --delete
flag to argocd app wait
and --wait
flag to argocd app delete
as proposed in #6085 to wait until the application delete event is received
Checklist:
- [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [x] The title of the PR states what changed and the related issues number (used for the release note).
- [x] The title of the PR conforms to the Toolchain Guide
- [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [x] Does this PR require documentation updates?
- [x] I've updated documentation as required by this PR.
- [x] I have signed off all my commits as required by DCO
- [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [ ] My build is green (troubleshooting builds).
- [ ] My new feature complies with the feature status guidelines.
- [x] I have added a brief description of why this PR is necessary and/or what this PR solves.
- [ ] Optional. My organization is added to USERS.md.
- [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
Codecov Report
Attention: 26 lines
in your changes are missing coverage. Please review.
Comparison is base (
52ffd7d
) 49.25% compared to head (8462b71
) 49.46%. Report is 3 commits behind head on master.
:exclamation: Current head 8462b71 differs from pull request most recent head b40a428. Consider uploading reports for the commit b40a428 to get more accurate results
Files | Patch % | Lines |
---|---|---|
cmd/argocd/commands/app.go | 0.00% | 25 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #16733 +/- ##
==========================================
+ Coverage 49.25% 49.46% +0.21%
==========================================
Files 274 271 -3
Lines 48170 47751 -419
==========================================
- Hits 23724 23620 -104
+ Misses 22099 21795 -304
+ Partials 2347 2336 -11
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @pasha-codefresh I have added unit and e2e tests, let me know if anything more needed, thanks
Thank you!