argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

fix: preserveUnkownField fix not applied when ignoreResourceStatus=all

Open imranismail opened this issue 1 year ago • 1 comments

This ensures the fix for CRD is applied even when using the ignoreResourceStatus=all option

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [x] The title of the PR states what changed and the related issues number (used for the release note).
  • [x] The title of the PR conforms to the Toolchain Guide
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).
  • [ ] My new feature complies with the feature status guidelines.
  • [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

imranismail avatar Dec 07 '23 04:12 imranismail

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.49%. Comparing base (f87897c) to head (89583de). Report is 119 commits behind head on master.

:exclamation: Current head 89583de differs from pull request most recent head 72cf123. Consider uploading reports for the commit 72cf123 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16565      +/-   ##
==========================================
- Coverage   49.73%   49.49%   -0.24%     
==========================================
  Files         274      270       -4     
  Lines       48948    47489    -1459     
==========================================
- Hits        24343    23507     -836     
+ Misses      22230    21671     -559     
+ Partials     2375     2311      -64     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 10 '23 23:12 codecov[bot]