feat: Show Traefik IngressRoute in network view
Displays the IngressRoute resource in the network view.
ExternalURLs dropdown is not populated here since it can be constructed by regexes both for path and hostnames, but the targeted Service's are connected and visualized.
Fixes #15368 <- enhancement proposal Fixes the IngressRoute part of #11934
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [x] The title of the PR states what changed and the related issues number (used for the release note).
- [x] The title of the PR conforms to the Toolchain Guide
- [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [ ] Does this PR require documentation updates?
- [ ] I've updated documentation as required by this PR.
- [ ] Optional. My organization is added to USERS.md.
- [x] I have signed off all my commits as required by DCO
- [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [x] My build is green (troubleshooting builds).
- [ ] My new feature complies with the feature status guidelines.
- [x] I have added a brief description of why this PR is necessary and/or what this PR solves.
Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.
Comparison is base (
aced025) 49.51% compared to head (96d7bba) 49.99%.
:exclamation: Current head 96d7bba differs from pull request most recent head b3d5de3. Consider uploading reports for the commit b3d5de3 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #15369 +/- ##
==========================================
+ Coverage 49.51% 49.99% +0.48%
==========================================
Files 269 263 -6
Lines 46972 45276 -1696
==========================================
- Hits 23257 22637 -620
+ Misses 21433 20421 -1012
+ Partials 2282 2218 -64
| Files | Coverage Δ | |
|---|---|---|
| controller/cache/info.go | 67.81% <85.36%> (+1.04%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
How can we progress here? Is there anything missing?
I was hoping for some feedback to come in, but I'm not chasing :)
It would be so nice if this got merged, but it's been a while and there are some tests failing + conflicts :(
It would be so nice if this got merged, but it's been a while and there are some tests failing + conflicts :(
Yeah it could be that a lot has happened since it was created so maybe it's not useful anymore. I could possibly update it again but I won't do it if noone will look at it :)