argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

Add context to "Watch failed"

Open jsoref opened this issue 1 year ago • 5 comments

Checklist:

  • [ ] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • [ ] I've included steps to reproduce the bug.
  • [ ] I've pasted the output of argocd version.

Describe the bug

https://cloud-native.slack.com/archives/C01TSERG0KZ/p1687186844752359?thread_ts=1687185656.068269&cid=C01TSERG0KZ

We see a lot of;

1 retrywatcher.go:130] "Watch failed" err="context canceled"

To Reproduce

Dunno

Expected behavior

Log messages should give enough context for someone reading them to understand what's going on, i.e. "I tried to do x and a watch failed".

Screenshots

Version

{
    "Version": "v2.7.4+a33baa3.dirty",
    "BuildDate": "2023-06-05T19:00:34Z",
    "GitCommit": "a33baa301fe61b899dc8bbad9e554efbc77e0991",
    "GitTreeState": "dirty",
    "GoVersion": "go1.19.6",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v5.0.1 2023-03-14T01:32:48Z",
    "HelmVersion": "v3.11.2+g912ebc1",
    "KubectlVersion": "v0.24.2",
    "JsonnetVersion": "v0.19.1"
}

Logs

Paste any relevant application logs here.

jsoref avatar Jun 20 '23 15:06 jsoref