argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

fix: error from `argocd app create` when using `--dest name` instead of `--dest server`

Open nirsht opened this issue 2 years ago • 2 comments

Fixes #10063

This error was created due to poor compare of apps Spec's.

In this PR I change the compare from reflect.DeepEqual to compare each property properly. The Destination weren't equal because we didn't use their compare function - https://github.com/argoproj/argo-cd/blob/41d4ce6fa4820f8790396fc2164b7d75e9139a8e/pkg/apis/application/v1alpha1/types.go#L2283

nirsht avatar Oct 08 '22 22:10 nirsht