argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

docs: update troubleshooting to reflect merge in argo-cd and add map examples in services

Open Sayrus opened this issue 3 years ago • 1 comments

This follows questions asked on #argo-cd-notifications:

  • It is not always clear whether the map keys are defined by ArgoCD or defined by the user. This small update aims to add example to ensure the information is clearer to the user. (If merged, generated docs will need an update: https://github.com/argoproj/notifications-engine/pull/104)
  • The troubleshooting page has a procedure for when argocd-notifications was not merged into argo-cd. The binary location is wrong and the ability to execute the client from the new image is not available.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • [X] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [X] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [X] Does this PR require documentation updates?
  • [X] I've updated documentation as required by this PR.
  • [ ] Optional. My organization is added to USERS.md.
  • [X] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).

Sayrus avatar Sep 14 '22 13:09 Sayrus

Codecov Report

Base: 45.76% // Head: 45.76% // No change to project coverage :thumbsup:

Coverage data is based on head (6ad67d4) compared to base (e53ab49). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10589   +/-   ##
=======================================
  Coverage   45.76%   45.76%           
=======================================
  Files         236      236           
  Lines       28519    28519           
=======================================
  Hits        13053    13053           
  Misses      13661    13661           
  Partials     1805     1805           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 14 '22 14:09 codecov[bot]

Closing for not really being relevant any longer. Feel free to reopen if you want to take up the cherry-pick option.

todaywasawesome avatar May 10 '24 22:05 todaywasawesome