chore: update robfig/cron to v3

[johejo]

Signed-off-by: Mitsuo Heijo [email protected]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• [ ] The title of the PR states what changed and the related issues number (used for the release note).
• [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• [ ] Does this PR require documentation updates?
• [ ] I've updated documentation as required by this PR.
• [ ] Optional. My organization is added to USERS.md.
• [x] I have signed off all my commits as required by DCO
• [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• [x] My build is green (troubleshooting builds).

[codecov[bot]]

Codecov Report

Base: 45.65% // Head: 45.65% // No change to project coverage :thumbsup:

Coverage data is based on head (966f871) compared to base (11c44f2). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #10588   +/-   ##
=======================================
  Coverage   45.65%   45.65%           
=======================================
  Files         236      236           
  Lines       28702    28702           
=======================================
  Hits        13104    13104           
  Misses      13804    13804           
  Partials     1794     1794           

Impacted Files	Coverage Δ
pkg/apis/application/v1alpha1/types.go	54.84% <ø> (ø)
controller/metrics/metrics.go	80.13% <100.00%> (ø)
util/settings/settings.go	51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[johejo]

This PR will maintain the old behavior for now. Deprecation of support for non-standard formats should be discussed in another issue.

[crenshaw-dev]

Should we also implement this for the cron instance in the metrics server? https://github.com/argoproj/argo-cd/blob/2c3bc81fcf7446c7da8fd5e8761839d6d724656d/controller/metrics/metrics.go#L196

By default, cron will no longer recover panics in jobs that it runs. Recovering can be surprising (see issue #192) and seems to be at odds with typical behavior of libraries. Relatedly, the cron.WithPanicLogger option has been removed to accommodate the more general JobWrapper type.

UPDATING: To opt into panic recovery and configure the panic logger:

cron.New(cron.WithChain( cron.Recover(logger), // or use cron.DefaultLogger ))

If folks are using cache expiration values that could somehow cause a panic in the cron library, I'm worried that the cron upgrade could crash their controller. Veeeeery small risk, but probably worth it since the fix seems very simple.