argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

docs: appset PR generator docs fixes

Open crenshaw-dev opened this issue 1 year ago • 1 comments

crenshaw-dev avatar Sep 11 '22 22:09 crenshaw-dev

Codecov Report

Base: 45.70% // Head: 45.68% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (7a4fd12) compared to base (a1279e0). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10567      +/-   ##
==========================================
- Coverage   45.70%   45.68%   -0.02%     
==========================================
  Files         236      236              
  Lines       28668    28668              
==========================================
- Hits        13102    13098       -4     
- Misses      13772    13775       +3     
- Partials     1794     1795       +1     
Impacted Files Coverage Δ
util/settings/settings.go 50.90% <0.00%> (-0.46%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 11 '22 22:09 codecov[bot]

i think this already fixed by this #10642

mabusaa avatar Oct 01 '22 09:10 mabusaa

@mabusaa resolved conflicts and left a few small changes. :-)

crenshaw-dev avatar Oct 01 '22 22:10 crenshaw-dev

@terrytangyuan fair. I think I'll save that for another cleanup PR. There are a lot of naming inconsistencies in the docs right now.

crenshaw-dev avatar Oct 02 '22 04:10 crenshaw-dev

I think it's worth adding an explanation for requeueAfterSeconds and when can it be used in the template spec page.

mubarak-j avatar Oct 11 '22 18:10 mubarak-j

Cherry-picked onto release-2.4 for 2.4.15 and release-2.5 for 2.5.0-rc3.

crenshaw-dev avatar Oct 12 '22 15:10 crenshaw-dev