argo-cd
argo-cd copied to clipboard
feat: add skip-test-tls flag to optionally skip testing for tls, fixes #9679
This issue fixes #9679 by implementing a new CLI flag --skip-test-tls
, which optionally skips checking whether the server is configured with tls.
As mentioned in the related issue, adding this flag is probably the best solution here: https://github.com/argoproj/argo-cd/issues/9679#issuecomment-1185752420
My company is blocked from updating the argocd-cli at the moment, same as many others using AWS ELB in the setup. This MR at least gives us a way forward by using the new flag.
Let me know if I need to make any further adjustments.
Thanks and best regards!
Signed-off-by: msvechla [email protected]
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [x] The title of the PR states what changed and the related issues number (used for the release note).
- [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [x] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [x] Does this PR require documentation updates?
- [x] I've updated documentation as required by this PR.
- [ ] Optional. My organization is added to USERS.md.
- [x] I have signed off all my commits as required by DCO
- [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [x] My build is green (troubleshooting builds).
Codecov Report
Base: 45.76% // Head: 45.75% // Decreases project coverage by -0.00%
:warning:
Coverage data is based on head (
4098fab
) compared to base (43dd2b3
). Patch coverage: 0.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #10484 +/- ##
==========================================
- Coverage 45.76% 45.75% -0.01%
==========================================
Files 234 236 +2
Lines 28460 28527 +67
==========================================
+ Hits 13025 13053 +28
- Misses 13658 13669 +11
- Partials 1777 1805 +28
Impacted Files | Coverage Δ | |
---|---|---|
cmd/argocd/commands/login.go | 2.17% <0.00%> (-0.08%) |
:arrow_down: |
pkg/apis/application/v1alpha1/repository_types.go | 58.06% <0.00%> (-10.55%) |
:arrow_down: |
util/argo/audit_logger.go | 88.00% <0.00%> (-7.66%) |
:arrow_down: |
server/application/logs.go | 81.25% <0.00%> (-4.47%) |
:arrow_down: |
util/argo/argo.go | 64.43% <0.00%> (-2.42%) |
:arrow_down: |
controller/state.go | 72.44% <0.00%> (-1.32%) |
:arrow_down: |
controller/sync.go | 54.05% <0.00%> (-1.29%) |
:arrow_down: |
reposerver/repository/repository.go | 61.04% <0.00%> (-0.92%) |
:arrow_down: |
server/project/project.go | 51.68% <0.00%> (-0.83%) |
:arrow_down: |
controller/appcontroller.go | 51.78% <0.00%> (-0.53%) |
:arrow_down: |
... and 19 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I rebased again, can someone please take a look?
@crenshaw-dev can you take a look maybe, as you also mentioned this as a preferred option here: https://github.com/argoproj/argo-cd/issues/9679#issuecomment-1185752420
Also I'd be comfortable marking this as a fix instead of a feature and backporting it to 2.4. @leoluz can you give a second opinion on that?
@crenshaw-dev thanks for the input, I addressed your comments. Let me know if I should change the commit to fix
instead of feat
Cherry-picked onto release-2.4 for 2.4.12.