argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

Update docs/operator-manual/application.yaml: fix kustomize namePrefix misconception

Open whyvez opened this issue 2 years ago • 1 comments

  • Removed comment about what namePrefix does. (i.e. it does not add a prefix to the image)
  • Added examples of other supported transformers. (based on looking at the source code)
  • Added link to the kustomize docs where the transormers are described in more detail.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).

whyvez avatar Aug 01 '22 17:08 whyvez

Codecov Report

Merging #10162 (ee7a1db) into master (7bd9e1e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10162   +/-   ##
=======================================
  Coverage   45.92%   45.92%           
=======================================
  Files         227      227           
  Lines       27403    27403           
=======================================
  Hits        12584    12584           
  Misses      13110    13110           
  Partials     1709     1709           
Impacted Files Coverage Δ
util/settings/settings.go 50.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7bd9e1e...ee7a1db. Read the comment docs.

codecov[bot] avatar Aug 01 '22 18:08 codecov[bot]

Cherry-picked onto release-2.4 for 2.4.9.

crenshaw-dev avatar Aug 03 '22 18:08 crenshaw-dev