argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

[Doc] Upgrade 2.3 to 2.4 - Clarify GitLab server prerequisites for private repo SSH keys

Open rcarre opened this issue 2 years ago • 2 comments

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [x] Does this PR require documentation updates?
  • [x] I've updated documentation as required by this PR.
  • [ ] Optional. My organization is added to USERS.md.
  • [x] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).

rcarre avatar Jul 29 '22 09:07 rcarre

Codecov Report

Merging #10135 (8795ec0) into master (506bd3b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10135   +/-   ##
=======================================
  Coverage   45.78%   45.78%           
=======================================
  Files         233      233           
  Lines       28383    28383           
=======================================
  Hits        12995    12995           
  Misses      13614    13614           
  Partials     1774     1774           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 29 '22 09:07 codecov[bot]

@rcarre looks like rendering in readthedocs is a little off. Can you check here? https://argo-cd--10135.org.readthedocs.build/en/10135/operator-manual/upgrading/2.3-2.4/

You can test locally with make servce-docs-local.

crenshaw-dev avatar Mar 14 '23 18:03 crenshaw-dev