argo-cd
argo-cd copied to clipboard
feat: add projects filter to app sync command (merge fix) (#8320)
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
- [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
- [x] The title of the PR states what changed and the related issues number (used for the release note).
- [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
- [x] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
- [x] Does this PR require documentation updates?
- [x] I've updated documentation as required by this PR.
- [x] Optional. My organization is added to USERS.md.
- [x] I have signed off all my commits as required by DCO
- [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
- [x] My build is green (troubleshooting builds).
Using the project filter we can sync apps that belong to a particular project
argocd app sync --project test --project dev
The above command would sync all apps in the projects test and dev
Closes: https://github.com/argoproj/argo-cd/issues/8320
This PR addresses a merge conflict from https://github.com/argoproj/argo-cd/pull/8343
I have tested this change locally. I'm still setting up the tooling but seems like an e2e test is in order as well. Should be able to free up some time this weekend to address that.
Codecov Report
Merging #10133 (464b121) into master (e3940cd) will increase coverage by
0.02%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #10133 +/- ##
==========================================
+ Coverage 45.88% 45.91% +0.02%
==========================================
Files 227 227
Lines 27373 27410 +37
==========================================
+ Hits 12560 12584 +24
- Misses 13109 13117 +8
- Partials 1704 1709 +5
Impacted Files | Coverage Δ | |
---|---|---|
cmd/argocd/commands/app.go | 20.27% <0.00%> (-0.10%) |
:arrow_down: |
util/db/gpgkeys.go | 77.14% <0.00%> (-1.97%) |
:arrow_down: |
util/gpg/gpg.go | 66.96% <0.00%> (-1.25%) |
:arrow_down: |
util/settings/settings.go | 50.90% <0.00%> (ø) |
|
pkg/apis/application/v1alpha1/app_project_types.go | 59.61% <0.00%> (+5.21%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e3940cd...464b121. Read the comment docs.