argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

feat: argocd app delete apps by label

Open danielhelfand opened this issue 2 years ago • 1 comments

Closes #10091

Allow argocd app delete command to delete apps having a common label. UX is argocd app delete -l foo=bar. Similar to argocd app sync -l experience.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).

danielhelfand avatar Jul 27 '22 21:07 danielhelfand

Codecov Report

Base: 45.70% // Head: 45.66% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (94c1f35) compared to base (66d82fc). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10118      +/-   ##
==========================================
- Coverage   45.70%   45.66%   -0.04%     
==========================================
  Files         236      236              
  Lines       28668    28690      +22     
==========================================
  Hits        13102    13102              
- Misses      13772    13794      +22     
  Partials     1794     1794              
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 18.75% <0.00%> (-0.27%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 27 '22 22:07 codecov[bot]

@danielhelfand if you resolve conflicts, I'll be happy to merge!

crenshaw-dev avatar Sep 30 '22 23:09 crenshaw-dev

@danielhelfand if you resolve conflicts, I'll be happy to merge!

Thanks again for looking everything over. I have resolved the conflicts.

danielhelfand avatar Oct 01 '22 00:10 danielhelfand