argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

Expose the Argo CD ID through an ENV in the Dockerfile #10113

Open rumstead opened this issue 2 years ago • 1 comments

Signed-off-by: rumstead [email protected]

closes #10113

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [x] The title of the PR states what changed and the related issues number (used for the release note).
  • [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] Optional. My organization is added to USERS.md.
  • [x] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).

rumstead avatar Jul 27 '22 18:07 rumstead

Codecov Report

Merging #10115 (1a4eef9) into master (44fea52) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10115   +/-   ##
=======================================
  Coverage   45.87%   45.87%           
=======================================
  Files         227      227           
  Lines       27373    27373           
=======================================
  Hits        12556    12556           
  Misses      13113    13113           
  Partials     1704     1704           
Impacted Files Coverage Δ
util/settings/settings.go 50.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44fea52...1a4eef9. Read the comment docs.

codecov[bot] avatar Jul 27 '22 18:07 codecov[bot]