applicationset fails to create application with name containing underscore character.

[yerinu2019]

GKE clustername contains underscore character. e.g. gke_-. When the argocd application name is set to -{{cluster}} in the argocd applicationset template, it fails with error like below with GKE cluster. This GKE cluster name is used in kubectl config get-contexts, and argocd app works with destination: name: {{cluster}} to copy git files to the destination GKE cluster. Should underscore character be allowed in argocd application template metadata.name?

Message: Application.argoproj.io "app1-gke_myproj-323514_us-central1-a_cluster1" is invalid: metadata.name: Invalid value: "app1-gke_myproj-323514_us-central1-a_cluster1": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is 'a-z0-9?(.a-z0-9?)*') Reason: UpdateApplicationError Status: False

[missingcharacter]

@yerinu2019 does https://github.com/argoproj-labs/applicationset/pull/390 fix your problem?