applicationset icon indicating copy to clipboard operation
applicationset copied to clipboard

ApplicationSet Controller overrides any Application CR changes

Open RichiCoder1 opened this issue 3 years ago • 6 comments

Related to #180.

Right now if you attempt to add annotations, labels, or do things like per-app parameter overrides, those changes are automatically and quickly overridden. It'd be nice if (either via config or by default) the controller merged the generated CR instead of overwriting it.

RichiCoder1 avatar Apr 06 '21 02:04 RichiCoder1

Related Comment: https://github.com/argoproj-labs/applicationset/issues/180#issuecomment-814328494

It's possible to disable syncing, but what this ticket wants to accomplish is enabling syncing, but having sync perform a merge instead of overwrite.

RichiCoder1 avatar Apr 06 '21 19:04 RichiCoder1

Having tried to implement this, it looks like the safest option might be a config option which stores the applied generated template and diffs against that to generate patches to live configuration. Has some shortfalls, but I think covers the 90% case.

RichiCoder1 avatar Apr 08 '21 16:04 RichiCoder1

When the application controller is configured with --policy create-only, the applications creation is managed by the controller but the applications can be changed or override

nhuray avatar Nov 26 '21 14:11 nhuray

My use case:

In Production, only the main/master branch can be deployed. In Testing, a PR/branch can be deployed as well. It would be nice if ApplicationSet controller could optionally ignore the targetRevision field so that engineers could manually change that field and deploy their features to a cluster using Argo.

This would also require the "Control resource modification on a per ApplicationSet basis" feature, which is currently a limitation.

fardin01 avatar Jan 19 '22 10:01 fardin01

Another use case is when some teams would like to have auto-sync enabled on their application and some other teams prefer to sync manually.

fardin01 avatar Feb 11 '22 16:02 fardin01

@RichiCoder1 Should this ticket be closed and tracked under https://github.com/argoproj/argo-cd/issues/9101 ?

jdomag avatar Apr 20 '22 08:04 jdomag