terraform-provider-argocd fix(argocd_cluster): use cluster list api to avoid 403 issues with cluster get api at cluster read time

fix(argocd_cluster): use cluster list api to avoid 403 issues with cluster get api at cluster read time

Open w4rgrum opened this issue 1 year ago • 12 comments

trafficstars

This PR fixes https://github.com/argoproj-labs/terraform-provider-argocd/issues/266

Coded it with below comment in mind, meaning it is backward compatible: https://github.com/argoproj-labs/terraform-provider-argocd/issues/266#issuecomment-1739138091

code does a Get as usual first (legacy code)
if it fails with a PermissionDenied error (i.e. 403) the fix is triggered (in a backward compatible way for servers <v2.8, see below) In that case a call is issued to the List api, reusing some code used for create cluster existence checks (that already uses this List api). Noe that this code is able to filter the cluster in the resulting list if not yet done by the ArgoCD server (servers filtering on List api does not work if <v2.8, see comments in linked issue and/or in the code ccomments)

Also added a non-regression test to validate a server-side deletion of the cluster triggers the fix.

Jun 12 '24 15:06 w4rgrum

@onematchfox PR is ready to be reviewed :)

Jun 13 '24 14:06 w4rgrum

any chance to have this released as new version of the provider? This seems to be a blocker when using the provider with recent ArgoCD versions