rollout-extension
rollout-extension copied to clipboard
Not able to see rollback button for rollout
Hi, I am using argo rollout extension 0.3.0 with rollout 1.2. I am not able to see rollback on "more" tab while all other options are available. Could you please guide on this.
Is there any update or plan for this issue?
I'm using the version 0.3.3 and I have the same bug
ArgoCD version: v2.9.0+9cf0c69 Build Date 2023-11-06T04:43:50Z
Here is my understanding on implementing the rollback button functionality for a rollout resource.
-
argo-rollouts: Add rollout rollback support from ArgoCD
- Set a flag in Argo rollout resource status.
status: undo: revision: 1
-
argo-cd: Add undo action for the argo rollouts custom resource actions
- There is no built-in action to undo a particular revision and needs to be added as per the
resource_actions
documentation here - A new
undo
action is required, which modifies therollout
resource withstatus.undo.revision
with the rollback revision number. - Upon setting the rollout
status.undo.revision
, the rollout controller reconciliation will act as per theundo
action and remove thestatus.undo.revision
. - This is dependent on the solution implemented for this proposal in argo-rollouts
- Enhancement proposal is here
- There is no built-in action to undo a particular revision and needs to be added as per the
-
argo-rollouts: Split the
interactive
object dependency forContainers
andRevision
Widgets here- The same
interactive
object is tightly coupled with bothRevisionWidget
andContainersWidget
(to render Containers and initContainers). - If we pass an
interactive
object forundo
functionality, it will also enable changing the images in the ContainersWidget. - Split with additional flags in the
interactive
object for both Revision and Containers widgets and make it backward compatible by making those flags to defaulttrue
. - Enhancement Proposal is here
- The same
-
rollout-extension: Add support to enable rollback button
- The
rollback
button will be displayed if we pass therollback
function toRevisionWidget
here - Need to pass the
interactive
api with the implementation ofrolloutServiceUndoRollout()
callback function so that theRevisionWidget
uses this here - This
rolloutServiceUndoRollout()
function should do a POST operation toargo-cd
applications resource action endpoint here - This task is dependent on all the above 1st, 2nd and 3rd points.
- The
Not sure if there are any other alternatives to achieve the rollback functionality from ArgoCD for Argo Rollout resource. If it looks okay, I can contribute for the 3rd and 4th points hoping that I can get help with 1st and 2nd points.
subscribed
+1 We are looking forward to this feature