argocd-vault-plugin icon indicating copy to clipboard operation
argocd-vault-plugin copied to clipboard

docs: :memo: Update installation doc

Open krausemi opened this issue 1 year ago • 3 comments

Description

Within this PR the custom docker file for the sidecar has been updated as the one which is currently available is not working. Furthermore the spawning of zombie bash processes has been avoided by using tini as entrypoint.

Fixes: https://github.com/argoproj-labs/argocd-vault-plugin/issues/460

Checklist

Please make sure that your PR fulfills the following requirements:

  • [x] Reviewed the guidelines for contributing to this repository
  • [x] The commit message follows the Conventional Commits Guidelines.
  • [x] Tests for the changes have been updated
  • [x] Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • [x] Docs have been added / updated
  • [ ] Optional. My organization is added to USERS.md.

Type of Change

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] New tests
  • [ ] Build/CI related changes
  • [x] Documentation content changes
  • [ ] Other (please describe)

Other information

krausemi avatar Mar 31 '23 14:03 krausemi

@krausemi can you sign-off on the commit for the DCO to pass? Thanks.

werne2j avatar Mar 31 '23 14:03 werne2j

@werne2j: done. Sorry for the little delay.

krausemi avatar Apr 04 '23 08:04 krausemi

Codecov Report

Merging #485 (90a4580) into main (b587367) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   75.31%   75.31%           
=======================================
  Files          25       25           
  Lines        1689     1689           
=======================================
  Hits         1272     1272           
  Misses        323      323           
  Partials       94       94           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Apr 04 '23 11:04 codecov-commenter