argocd-operator
argocd-operator copied to clipboard
Added reconcilation logic if spec.ApplicationSet is removed
Signed-off-by: rishabh625 [email protected]
What type of PR is this?
Uncomment only one
/kind
line, and delete the rest. For example,> /kind bug
would simply become:/kind bug
/kind bug /kind chore /kind cleanup /kind failing-test /kind enhancement /kind documentation /kind code-refactoring
/kind bug
What does this PR do / why we need it: This PR deletes application set resources if disabled.
Have you updated the necessary documentation?
- [ ] Documentation update is required by this PR.
- [ ] Documentation has been updated.
Which issue(s) this PR fixes:
Fixes #627 Fixes #628
How to test changes / Special notes to the reviewer:
Sure will look at all Thanks @iam-veeramalla
@rishabh625
I think the nil pointer reference @iam-veeramalla mentioned is coming from here https://github.com/argoproj-labs/argocd-operator/pull/670/files#diff-547555dfe97d80ddf6097444f1cc82263cce61c48fbb67f6bb8e08c657873bc6L46
we should check if cr.spec.applicationset != nil
first
@rishabh625 I think the nil pointer reference @iam-veeramalla mentioned is coming from here https://github.com/argoproj-labs/argocd-operator/pull/670/files#diff-547555dfe97d80ddf6097444f1cc82263cce61c48fbb67f6bb8e08c657873bc6L46 we should check if
cr.spec.applicationset != nil
first
thanks @jaideepr97 will look into this, was waiting for discussion