argocd-operator icon indicating copy to clipboard operation
argocd-operator copied to clipboard

ability to set annotations+labels on pods created by argocd

Open Morriz opened this issue 3 years ago • 5 comments

Is your feature request related to a problem? Please describe. Hi, we need to set annotations on any pods running on our cluster, but I can't find the option to do so on pods deployed by argo.

Describe the solution you'd like Something like:

apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
...
controller:
  podAnnotations:
    some: anno
  labels:
    some: label
...
server:
  podAnnotations:
    ana: da

Morriz avatar May 05 '22 16:05 Morriz

A better question to ask is: Why does the operator not support the exact same options as the helm charts? Istio Operator does the same, as do other operators. It would be trivial and super beneficial

Morriz avatar May 05 '22 16:05 Morriz

@Morriz I agree it is very useful, but I see a concern with operator reconciling the labels and annotations. There is a good chance that operator may removes annotations/labels set by admission controllers. WDYT ?

iam-veeramalla avatar May 13 '22 07:05 iam-veeramalla

@Morriz I agree it is very useful, but I see a concern with operator reconciling the labels and annotations. There is a good chance that operator may removes annotations/labels set by admission controllers. WDYT ?

That is a matter of having a mature operator that allows for labels it does not manage. That is why one namespaces them, in order to filter.

Morriz avatar May 18 '22 09:05 Morriz

LGTM. Would you like to work on this one ? If not I can add the label help-wanted and remove traige-required.

Thanks @Morriz

iam-veeramalla avatar May 18 '22 10:05 iam-veeramalla

I am no Go dev unfortunately, and my calendar is rather full ;|

Morriz avatar May 18 '22 11:05 Morriz