argocd-operator icon indicating copy to clipboard operation
argocd-operator copied to clipboard

add option to enable Service Monitor deployment

Open maratsal opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. Currently operator supports deployment of prometheus instance within argocd object deployment. It would be great to have option to enable deployment of just service monitors to collect metrics by existing prometheus installation on the cluster.

Describe the solution you'd like would be something like this:

apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: example-argocd
  labels:
    example: insights
spec:
  metrics:
    serviceMonitor:
      enabled: true

or more granularly

apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: example-argocd
  labels:
    example: insights
spec:
  metrics:
    serviceMonitor:
      applicationController:
        enabled: true
      apiServer:
        enabled: true
      repoServer:
        enabled: true

Describe alternatives you've considered currently deploying service monitors separately along with argo cd.

Additional context N/A

maratsal avatar Jan 20 '22 18:01 maratsal

Would be awesome. Not much work to implement ;)

Morriz avatar Apr 25 '22 14:04 Morriz

@jopit What do you think about this one ?

iam-veeramalla avatar Apr 25 '22 17:04 iam-veeramalla