argocd-operator icon indicating copy to clipboard operation
argocd-operator copied to clipboard

`make bundle` does not work on MacOS

Open appiepollo14 opened this issue 4 months ago • 3 comments

Describe the bug When running make bundle on MacOS, it exits premature with an error statement:

sed: 1: "bundle/manifests/argocd ...": undefined label 'undle/manifests/argocd-operator-webhook-service_v1_service.yaml' make: *** [bundle] Error 1

This causes the generated bundle to not complete. Which led to a PR not passing CI, as the bundle is different than when it is generated on Linux in CI.

The rootcause is that there are some sed statements in the make statement which have unexpected behavior on MacOS exiting make.

To Reproduce Steps to reproduce the behavior: use a MacOS system!

  1. open a cmd
  2. execute: make bundle

Expected behavior Execute make bundle without an error caused by sed

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Solution / explanation of the difference between sed on systems is posted here: https://stackoverflow.com/questions/12272065/sed-undefined-label-on-macos

appiepollo14 avatar Oct 14 '24 06:10 appiepollo14