argocd-operator icon indicating copy to clipboard operation
argocd-operator copied to clipboard
verified publisher icon argoproj-labs

Add support for multiarch images, include ARM64

Open lwj5 opened this issue 1 year ago • 4 comments

What type of PR is this?

Uncomment only one /kind line, and delete the rest. For example, > /kind bug would simply become: /kind bug

/kind enhancement

What does this PR do / why we need it:

Support for building ARM64 images

Have you updated the necessary documentation?

  • [ ] Documentation update is required by this PR.
  • [ ] Documentation has been updated.

Which issue(s) this PR fixes:

  • Fixes #264

How to test changes / Special notes to the reviewer:

I see a set up go and go cache here, but doesn't seem to be used

https://github.com/argoproj-labs/argocd-operator/blob/e5872c5151e2028420d136bd64d1b92c6255f91b/.github/workflows/publish.yaml#L22

If you would like, E2E tests can be added for macOS runner to test arm64

lwj5 avatar Jul 10 '24 11:07 lwj5

@iam-veeramalla @svghadi

Hope you can help review

lwj5 avatar Jul 11 '24 09:07 lwj5

Hi @lwj5 , thanks for the PR. I will try to get to it in next few days.

svghadi avatar Jul 11 '24 16:07 svghadi

Any updates or feedback would be good

lwj5 avatar Jul 21 '24 14:07 lwj5

Hi! Is this pull request active? I'd like to help move it along, if I can :-)

homburg avatar Jul 04 '25 08:07 homburg