argocd-image-updater icon indicating copy to clipboard operation
argocd-image-updater copied to clipboard

Support for multisource + upgrade k8s and argocd pkg + update to go 1.20 (fix #513)

Open Tronix117 opened this issue 1 year ago • 12 comments

Functional, however unit tests for multi-source needs to be updated.

fix: #513

Tronix117 avatar Mar 30 '23 16:03 Tronix117

Nice! Can we please decouple the upgrade of Argo CD, update of Go and the functional changes in three separate PRs?

jannfis avatar Mar 31 '23 23:03 jannfis

I can make two PRs :

  • one for update of GO and argoCD and K8S (because they are all related, k8s new dependencies versions are only compatible with go > 1.19)
  • this one for the multiple sources (but this one should be based on the other one, because we need new argocd, and thus new k8s version)

I still need to add some unit test for that, I'll do it when I can.

Tronix117 avatar Apr 03 '23 11:04 Tronix117

I can make two PRs

Sounds reasonable, thanks!

jannfis avatar Apr 03 '23 13:04 jannfis

Thank you! we were developing something very similar, let me know if I can help.

amedinagar avatar Apr 13 '23 13:04 amedinagar

Hey everyone! I've tested this PR in our environment and looks like it is working with multisource, to help this feature be available in a future release of argocd-image-updater I've already created the PR to bump golang release in a new pull request https://github.com/argoproj-labs/argocd-image-updater/pull/564

deferraz avatar May 08 '23 19:05 deferraz

I tested the changes briefly, I noticed that it only updates the first element of the array when using multi source :

  sources: 
    - chart: elasticsearch # works
      repoURL: https://helm.elastic.co
      targetRevision: 8.5.1
    - repoURL: https://github.com/argoproj/argocd-example-apps.git # not works
      path: guestbook
      targetRevision: HEAD

binboum avatar May 18 '23 16:05 binboum

any plan when you will merge and release these feature?

an-sy avatar May 21 '23 14:05 an-sy

I tested too. Same behavior as mentioned by @binboum.

sources:
    - chart: ingress-nginx
      repoURL: https://kubernetes.github.io/ingress-nginx
      targetRevision: 4.4.2
      helm:
        releaseName: ingress-nginx
        valueFiles:
          - $values/infrastructure/production/infra-values/ingress-nginx/values.yaml        
    - ref: values
      repoURL: [email protected]:mecsys/mecsys-gitops.git
      targetRevision: main

mecsys avatar Jul 08 '23 18:07 mecsys

Hello,

any news on this feature ? It would be nice to implement this as we are generalizing the use of multi source app :)

kvlxj avatar Sep 07 '23 12:09 kvlxj

Hey,

any plan when you will merge and release these feature?

Thanks !

Iliabuleh avatar Sep 18 '23 12:09 Iliabuleh

Seems like this PR is likely massively out of date. When will this get merged? I mean, it makes the project basically unusable when using multiple sources.

dermicus-miclip avatar Sep 27 '23 11:09 dermicus-miclip

Has any movement happened with this?

devopsidiot avatar Nov 11 '23 01:11 devopsidiot