argocd-image-updater icon indicating copy to clipboard operation
argocd-image-updater copied to clipboard

Documentation: ArgoCD apps in any namespace incompatibility

Open seanmorton opened this issue 1 year ago • 2 comments

For those using Applications in any namespace, the docs should mention that Image Updater is not compatible with any Application resources installed in namespaces other than argocd.

seanmorton avatar Mar 20 '23 22:03 seanmorton

That is unfortunate. This is exactly what I'm doing and I just installed and deployed it :D

ElanHasson avatar Dec 21 '23 04:12 ElanHasson

This is a dupe of #601 and #612 cover this.

ElanHasson avatar Dec 21 '23 04:12 ElanHasson

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.16%. Comparing base (fc1999f) to head (77146fe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   56.16%   56.16%           
=======================================
  Files          31       31           
  Lines        3105     3105           
=======================================
  Hits         1744     1744           
  Misses       1222     1222           
  Partials      139      139           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 26 '24 16:06 codecov-commenter

Looks like most recent effort to add support for this was closed: https://github.com/argoproj-labs/argocd-image-updater/pull/672

Could we merge this warning so folks are at least aware? My latest change also adds a brief warning about this to the documentation root.

seanmorton avatar Jun 26 '24 17:06 seanmorton

Thanks @seanmorton @ElanHasson @JStacy86 for the fix and review!

chengfang avatar Jun 26 '24 19:06 chengfang

Hasn't #687 added the support of Applications in any Namespace?

mcanevet avatar Jun 27 '24 05:06 mcanevet

@mcanevet thanks for pointing that out. @seanmorton @ElanHasson @JStacy86 could you please verify if the current master branch works for you when using image-updater for apps in any namespace?

chengfang avatar Jun 27 '24 16:06 chengfang

I can confirm the image-updater can work with apps in any namespace if you use the APPLICATIONS_API approach. https://github.com/argoproj-labs/argocd-image-updater/issues/601#issuecomment-2249819819

wd avatar Jul 30 '24 09:07 wd