argocd-image-updater icon indicating copy to clipboard operation
argocd-image-updater copied to clipboard

Image Updater shouldn't update Images which are reverted manually

Open kahootali opened this issue 2 years ago • 1 comments

Is your feature request related to a problem? Please describe. I am using ArgoCD image updater with the following annotation to match my image tags

    argocd-image-updater.argoproj.io/app.update-strategy: latest
    argocd-image-updater.argoproj.io/app.allow-tags: regexp: MY_REGEX

and image-updater works fine, and updates the image and pushes back to github, but if there is an issue with new image and I or other developers need to revert to an older version, then issue arises. As I update github with old version manually but image-updater again updates to newer version, there should be a way of controlling this...

I know of ignore-tags option but that doesn't seem viable in our case as the developers cant change Argocd apps, rather they know the helm values only.

Describe the solution you'd like Somehow check if the image is manually overriden by a commit in git after image-updater's commit, then dont auto-update it.

kahootali avatar Jun 22 '22 08:06 kahootali

This is a major bug rather, I just tested by even pushing a new image so that timestamp changes, and changing the tag to newly create image tag manually in git repo, but argocd-image-updater plugin still reverts it...

https://argocd-image-updater.readthedocs.io/en/latest/configuration/images/#update-strategies here it states that for latest it update to the tag with the most recent creation date

but now in my case the tag that matches the regex has older creation date than the one manually changed in git, still its reverting

kahootali avatar Jun 23 '22 14:06 kahootali

+1

Noamshmueli avatar Jul 13 '23 15:07 Noamshmueli