argocd-image-updater icon indicating copy to clipboard operation
argocd-image-updater copied to clipboard

feat(chart-updater): continuous deployment of OCI Helm chart type application

Open distorhead opened this issue 2 years ago • 6 comments

Hi! There is a proposal to implement continuous deployment at the higher logical level than updating images: watch for a new helm chart versions and perform update (and included images will be updated as well). This proposal and possible solutions has been described in-depth in this issue: https://github.com/argoproj/argo-cd/issues/8475.

In this PR I've created MVP to try one solution to the problem and get your feedback if possible.

How it works

Update application targetRevision for an OCI helm chart when new chart version arrives into the container registry based on semver constraints.

distorhead avatar Mar 15 '22 08:03 distorhead

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 15 '22 08:03 CLAassistant

Codecov Report

Merging #405 (1df2f88) into master (e46a206) will decrease coverage by 2.46%. The diff coverage is 14.70%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   65.55%   63.08%   -2.47%     
==========================================
  Files          21       21              
  Lines        2032     2132     +100     
==========================================
+ Hits         1332     1345      +13     
- Misses        571      656      +85     
- Partials      129      131       +2     
Impacted Files Coverage Δ
pkg/argocd/update.go 53.10% <0.00%> (-16.32%) :arrow_down:
pkg/argocd/argocd.go 65.13% <60.00%> (-1.26%) :arrow_down:
pkg/argocd/git.go 64.84% <0.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar Mar 15 '22 08:03 codecov-commenter

@jannfis Could you please review this ? Thank you so much

bsg-toby avatar Jul 27 '22 09:07 bsg-toby

@jannfis Thanks in advance for your review.

dtduc-git avatar Jul 27 '22 09:07 dtduc-git

@jannfis We really need this feature!

minhnnhat avatar Jul 27 '22 09:07 minhnnhat

@distorhead Could you accept the licensing and go forward with this feature?

mxzinke avatar Sep 30 '22 13:09 mxzinke

@distorhead Could you accept the licensing and go forward with this feature?

@mxzinke Hi! I am sorry for delayed response, accepted licensing.

distorhead avatar Oct 18 '22 11:10 distorhead

@jannfis Hi! What do you think about this feature? Does it have any problems with design?

distorhead avatar Nov 10 '22 16:11 distorhead

Hi @jannfis,

Could you please take a look on this PR ? Thanks.

bsg-toby avatar Nov 24 '22 05:11 bsg-toby

@alexmt @jannfis anyone could take a look this pr ? thanks

vietwow avatar Dec 13 '22 16:12 vietwow

Any chance this will go forward?

asychev avatar Feb 08 '23 13:02 asychev

I really don't understand what's wrong with this PR and why repo maintainers like @jannfis don't care about this while many people are waiting for this.

vietwow avatar Jul 14 '23 13:07 vietwow