argocd-image-updater icon indicating copy to clipboard operation
argocd-image-updater copied to clipboard

add the ability to specify filename for helm based git write back target

Open rafedramzi opened this issue 3 years ago • 6 comments

based on feature request: https://github.com/argoproj-labs/argocd-image-updater/issues/287

edit:

  • the original commit was force pushed because the old one was unsigned

rafedramzi avatar Nov 03 '21 18:11 rafedramzi

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 03 '21 18:11 CLAassistant

Hey, apologies for coming so late to this one! I was just thinking, that this is not specific to Helm, because it really is writing the app source YAML, just to a different path.

So, I think the write-back-target parameter name should not be helm (and not exclusively associated to applications of type Helm at all), but probably should be named app-source and work for both, Kustomize and Helm (and later on, possibly other) types of applications.

jannfis avatar Dec 16 '21 20:12 jannfis

Hi,

any update on this feature request? We really need it.

Thanks.

albeldas avatar Jun 22 '22 12:06 albeldas

any update on this ? seems like it would be very nice to merge the feature but still no review

ixxeL2097 avatar Jun 30 '23 22:06 ixxeL2097

This is what we are looking for!

An update would be greatly appreciated, thanks! 👍

Reyalsorik avatar Aug 21 '23 20:08 Reyalsorik

I think this was achieved in #636

aqeelat avatar Feb 08 '24 21:02 aqeelat