argocd-image-updater icon indicating copy to clipboard operation
argocd-image-updater copied to clipboard

Recent releases break kustomize when tracking latest with digest

Open Sovietaced opened this issue 10 months ago • 3 comments

Describe the bug

We recently upgraded the Argo CD Image Updater (from an old fork off of v0.13) and found a regression where Kustomize patches were broken and Argo CD was trying to synchronize the image defined in the original deployment manifest.

My suspicion is that the way the image is now written to the kustomize patch is not compatible with Argo CD (or at least the version that we're running which is 2.8).

This is the change that we noticed in the image tag. It now seems to include the immutable tag as well as the digest.

git diff

kustomize:
  images:
 (-) - <redacted>_svc@sha256:21e88fb9c107f10ad274a7703a6d56cf47e737cc3981c36c1a73ac31a388ca16 # (old)
 (+) - <redacted>_svc:latest@sha256:df8c34bb660b52b645c7df13431b41df65b6900db71b9162d31f6e7d1bf20fcc # (new)

Additional context We are using Argo CD Server v2.8.0 We are using the instructions listed here: https://argocd-image-updater.readthedocs.io/en/release-0.15/configuration/images/#tracking-an-images-latest-tag

Sovietaced avatar Jan 08 '25 01:01 Sovietaced

This may be related: https://github.com/kubernetes-sigs/kustomize/issues/4713

Sovietaced avatar Jan 08 '25 01:01 Sovietaced

the kustomize issue you mentioned above was fixed in kustomize v5.4.0. I think more recent versions of argo-cd should already have this fixed version or later. In the current argo-cd master branch, the kustomize version is 5.4.3:

https://github.com/argoproj/argo-cd/blob/master/hack/tool-versions.sh#L17

which image-updater version are you using? The latest is 0.15.2 should be used if you're using 0.15.x

chengfang avatar Jan 08 '25 03:01 chengfang

the kustomize issue you mentioned above was fixed in kustomize v5.4.0. I think more recent versions of argo-cd should already have this fixed version or later. In the current argo-cd master branch, the kustomize version is 5.4.3:

https://github.com/argoproj/argo-cd/blob/master/hack/tool-versions.sh#L17

which image-updater version are you using? The latest is 0.15.2 should be used if you're using 0.15.x

Thank you, I will try a newer version of Argo CD server. I was using the latest image-updater version.

Sovietaced avatar Jan 08 '25 03:01 Sovietaced