argocd-image-updater icon indicating copy to clipboard operation
argocd-image-updater copied to clipboard

Published 20 hours ago • verified publisher icon argoproj-labs

feat: Trigger image update check on incoming webhook and/or other triggers

Open jannfis opened this issue 4 years ago • 23 comments

Is your feature request related to a problem? Please describe.

Currently, ArgoCD Image Updater only polls container registries for new tags at a given interval. Depending on the number of images and registries to be checked, this can lead to an overwhelming number of requests and takes a lot of time.

Describe the solution you'd like

Update checks for images should also be triggered asynchronously, i.e. by a webhook on image push to the registry.

jannfis avatar Aug 06 '20 07:08 jannfis

Per some of the constraints at my employer, this feature would be a game changer there. I was wondering if there is a timeline on this, and if there is anything I can do to help (unfortunately, I do not know Go).

ghostheory avatar Mar 23 '21 14:03 ghostheory

Per some of the constraints at my employer, this feature would be a game changer there. I was wondering if there is a timeline on this, and if there is anything I can do to help (unfortunately, I do not know Go).

I second this feature. Would be very helpful for us as well.

Ladorie avatar Mar 23 '21 15:03 Ladorie

Same here! This would be a game changer and extremely valuable!

tylerbroadbent avatar Mar 23 '21 15:03 tylerbroadbent

Serious game changer! This would be a great add.

joshdwads avatar Mar 23 '21 15:03 joshdwads

+1

nikelsj11 avatar Sep 04 '21 21:09 nikelsj11

Game changer here!

alexisbel1 avatar Oct 02 '21 15:10 alexisbel1

Same here!

gastonborba avatar Nov 18 '21 14:11 gastonborba

@gastonborba i opened a PR earlier here. it's wip #284

tuananh avatar Nov 18 '21 14:11 tuananh

Plz do this

Disturbing avatar Jan 11 '22 12:01 Disturbing

It would be amazing if the image updater could be triggered through the git webhook for refreshing argocd apps.

Git repositories POST to https://argocd.example.com/api/webhook, the image updater triggers for applications with annotations that match the git webhook. That way, all the user has to do is set some annotations, and then get a free ride with the existing ArgoCD git webhook functionality.

djfinnoy avatar Apr 28 '22 20:04 djfinnoy

git webhook is triggered very early in the CI process. at that moment, CI was just trigger and image is not built in.

the other information is git webhook payload doesn't have any information of the image tag, so image updater doesn't know which one to use for updating either.

tuananh avatar Apr 28 '22 23:04 tuananh

How about when the CI process completed the image creating it will send a web request to ArgoCD ? is it already implemented on Argo Events ?

chenfli avatar May 10 '22 15:05 chenfli

This would be a game changer for us as well. With a growing number of repositories and images, it takes quite sometime to update new image and it is slowing down our CD

binhnguyenduc avatar Oct 12 '22 03:10 binhnguyenduc

This would be a game changer for us as well. With a growing number of repositories and images, it takes quite sometime to update new image and it is slowing down our CD

Maybe you can continue on this pr https://github.com/argoproj-labs/argocd-image-updater/pull/284

tuananh avatar Oct 12 '22 03:10 tuananh

Any updates on this feature?

gain620 avatar Feb 05 '23 12:02 gain620

Would be amazing to have

otherguy avatar Mar 03 '23 11:03 otherguy

tracking hundreds of images and my GCP project has exceeded the Snapshot api limit, this feature is really really important imo

MrCorncob avatar May 10 '23 07:05 MrCorncob

This could be the implementation of API request as /api/webhook?name=app-name, however this is thin line. Github Webhook currently does not support OIDC or any other ways of authenticating, therefore wanting for the new rollout to start by un-authenticated request or not is another question

victorbiga avatar Jul 03 '23 19:07 victorbiga