argocd-autopilot icon indicating copy to clipboard operation
argocd-autopilot copied to clipboard

feat: allow --provider for all git commands (and add GIT_PROVIDER env)

Open hojerst opened this issue 2 years ago • 3 comments

added --provider flag to all git repository based commands as those will fail otherwise when autodetection doesn't work (e.g. internal git repository)

hojerst avatar Jun 25 '22 00:06 hojerst

Fixes #290

hojerst avatar Jun 29 '22 10:06 hojerst

I am not familiar with the codebase so I am not sure if this will work out but the changes look ok to me. Can any of the maintainers review the PR and check if we can get this in the next argocd-autopilot release?

I suspect that for many organisations running private gitlab instances which are trying out argocd-autopilot this would be a big decider 😄 Especially that the required changes (based on the PR) look relatively small.

Hope someone can tak a look ✌️

lblazewski avatar Jul 06 '22 16:07 lblazewski

The City of Davenport is one such organization that needs this feature 🙏 Thanks for this great tool and you guys rock!!

jeremyj563 avatar Jul 08 '22 17:07 jeremyj563

as i commented in #290 - the --provider is only required when creating a new repository (using provider api calls). not when performing any of the other operations (which are git-only, and provider-agnostic). please let me know if you think i should re-open this PR or the original issue.

noam-codefresh avatar Sep 20 '23 16:09 noam-codefresh