Clayton Smith
Clayton Smith
Sorry for the delay in looking at this. In general, the user interface here looks good. A couple observations: * The "Rename" function is also accessible from the "New bookmark"...
After renaming a tag from within the Bookmarks dock, the following is printed at the console: ``` QAbstractItemView::closeEditor called with an editor that does not belong to this view ```...
> Maybe you were using Qt < 6.4. I've been using Qt 6.4 for quite a while. What I meant is that I haven't seen this error message prior to...
> Or is it better to squash it into two commits: memory leak fixes and tag renaming feature? That sounds good, and should make the code easier to review.
> When I give the command F 14450000, the frequency is set, but with a offset relative to the center by 432 kHz. Why is it so and how to...
> And why is the maximum sensitivity only in the 200kHz band? I use Sdrplay and in SDRUno for Windows, I see a band up to 10MHz I don't know...
Thank you for your contribution. Unfortunately, `C` can't be used for this purpose, because Gqrx maintains compatibility with the rigctl protocol, and `C` is already assigned to "set CTCSS tone"....
> Would a symbol like ^ be fine? I would suggest using a long command name like `gqrx_set_hw_freq`. #1422 adds such a command already, which I suspect has the same...
Thanks for the contribution. I agree it's annoying that DSP processing doesn't stop when the end of the file is reached. One thing I wonder about though: the UI slider...
Yes, the problem with the Windows build was fixed on the master branch after you created your PR.