select2-rails icon indicating copy to clipboard operation
select2-rails copied to clipboard

Rails 6 and Dependency issues (Thor)

Open joshm1204 opened this issue 4 years ago • 5 comments

Trying to upgrade to rails 6 and got the below error.


rails (~> 6.0, >= 6.0.2.1) was resolved to 6.0.2.1, which depends on
      railties (= 6.0.2.1) was resolved to 6.0.2.1, which depends on
        thor (>= 0.20.3, < 2.0)

    select2-rails was resolved to 4.0.3, which depends on
      thor (~> 0.14)

I assume select2-rails needs to update it's dependency requirements to make it compatible with rails 6.

joshm1204 avatar Dec 27 '19 13:12 joshm1204

I think you just have to update thor. Thor version 0.20.3 is compatible with 0.14. I know because we have thor version 0.20.3 installed and select2-rails.

Update your thor library: bundle update thor

williamweckl avatar Jan 06 '20 20:01 williamweckl

still it would be wonderful to have an update with thor 1.0.1

seb-sykio avatar Jan 08 '20 01:01 seb-sykio

@seb-sykio Would be perfect! Looking forward for the result of this thread: https://github.com/argerim/select2-rails/issues/193#issuecomment-571320673

williamweckl avatar Jan 08 '20 01:01 williamweckl

Thor is only used for rake update-select2 task that is used to update select2 code from upstream (also renames i18n files), I think it should be a development dependency, or at least optional

Vasfed avatar Feb 04 '20 17:02 Vasfed

@Vasfed You are correct, for this gem thor is just for development. There is also a rake task that will update the select2 dependencies. Anyhow, select2-rails now requires thor ~> 1 hopefully that resolves this issue.

@joshm1204 Can you test this with your rails 6 app?

OpenCoderX avatar Jun 28 '20 03:06 OpenCoderX