web3.swift icon indicating copy to clipboard operation
web3.swift copied to clipboard

GenericJSON dependency causing "Conversion to Swift 5 is available" warning

Open simonmcl opened this issue 2 years ago • 2 comments

There is a bug in Xcode 13 that when scanning code to see is it written in Swift 5, it also scans imported swift packages to see are they using Swift 5. If not it presents you with a warning encouraging you to convert the code. But because its in an uneditable package, its not possible to act on.

I'm using a package that has this and others as a dependency, i'm reaching out to all that have a v4 in the chain to see can they do something to help get rid of this warning

One of your dependencies "GenericJSON" hasn't been updated in years and is using Swift v4, theres been a PR opened since April last year to fix it, but its been left open. Would it be possible for you to use a fork of GenericJSON thats been updated to v5? or if possible remove it all together since its not being maintained

Thanks

simonmcl avatar May 17 '22 11:05 simonmcl

Thanks @simonmcl will see what we can do. What's the updated fork? Removing the package not an easy option as it's used actively for feature related to signing typed data.

DarthMike avatar May 18 '22 09:05 DarthMike

@DarthMike The package you are using has a PR with it fixed (I hope) here: https://github.com/zoul/generic-json-swift/pull/36 you can see the fork from there

simonmcl avatar May 18 '22 09:05 simonmcl