Andrii Gladkyi

Results 21 comments of Andrii Gladkyi

@dblock could you please take a look, I made all the requested changes but PR is still in "changes requested" state for some reason.

> @arg want to finish this? Yes, I will. A bit busy now but will try to find some time in the next few days.

> @DmytroVasin thanks for the deep dive, makes sense, let's get this PR finished and make sure we have the right specs - is there anything else missing here? @dblock...

@dblock @DmytroVasin sorry, have been quite busy the last couple of months. So anyways, I added test to cover scenario when both `route_param` and regular param are defined with same...

Hey, thanks for reminding and sorry for the delay. I’m coming back tomorrow and will try to find some time to finish the PR.

It looks like all requested changes are applied, please review

I've got the same error trying to compile on the latest macOS (ARM): ``` error: linking with `cc` failed: exit status: 1 | = note: LC_ALL="C" PATH="/Users/arg/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/bin:/Users/arg/.rbenv/shims:/Users/arg/.cargo/bin:/Users/arg/.rbenv/shims:/opt/homebrew/sbin:/opt/homebrew/bin:/Users/arg/.local/bin:/opt/homebrew/opt/fzf/bin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin" VSLANG="1033" "cc" "-Wl,--as-needed"...

Got the PR: https://github.com/AkhileshNS/heroku-deploy/pull/151

:+1: for the approach from the comment above. We ran into the same problem. First we used a workaround: ``` $(this).find('button[type="submit"]').removeAttr('data-disable-with') ``` This code, added to the `ajax:success` callback, removes...