Tasmota icon indicating copy to clipboard operation
Tasmota copied to clipboard

add support for ams5915 and ams6915 temerature and pressure sensors

Open baschdello opened this issue 1 year ago • 2 comments
trafficstars

Description:

Adds support for another sensor: AMS5915 and AMS6915 from Analog Microelectronics. There are many types of these sensor series available for various pressure ranges. Pressure range can be set with sensor command Sensor114. Pmin and Pmax of sensor is saved at sensor configfile on the filesystem (as discussed in #15791). If filesystem is not available then pmin and pmax defaults to 0. Command example for sensor type "AMS 5915-0005-D-B" (differential and bidirectional): Sensor114 -5 5

Related issue (if applicable): fixes #<Tasmota issue number goes here>

Checklist:

  • [x] The pull request is done against the latest development branch
  • [x] Only relevant files were touched
  • [x] Only one feature/fix was added per PR and the code change compiles without warnings
  • [x] The code change is tested and works with Tasmota core ESP8266 V.2.7.5
  • [ ] The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • [x] I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

baschdello avatar Jan 17 '24 15:01 baschdello

Hi s-hadinger, good points. I will check and edit asap.

baschdello avatar Jan 17 '24 16:01 baschdello

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 16 '24 15:02 github-actions[bot]

This PR was automatically closed because of being stale.

github-actions[bot] avatar Feb 21 '24 15:02 github-actions[bot]

Hello, I had time to test the code on the ESP32 and it works. I've noticed and fixed a missing initialisation of variable 'i'. Do I have to make a fresh pull request to get the sensor code merged into tasmota? Best regards Bastian

baschdello avatar Feb 26 '24 14:02 baschdello

Makes sense allowing us to chk if all above items have been fixed too.

arendst avatar Feb 26 '24 14:02 arendst