Tasmota icon indicating copy to clipboard operation
Tasmota copied to clipboard

VINDRIKTNING PM1006 active control of measurement requests and fan by ESP

Open jenicek001 opened this issue 2 years ago • 11 comments

Description:

Particle sensor PM1006 used in IKEA VINDRINKTNING product requires an active control to get measurement results. The original implementation of VINDRIKTNING support in Tasmota was relying the original VINDRIKTNING MCU/PCB to generate measurement requests to PM1006 sensor and controlling the fan. This functionality is now implemented in Tasmota, so ESP8266 or ESP32 fully control the PM1006 - specifically sensing serial Tx requests once per 60 seconds and switching on the fan 10s before a measurement is taken.

Related issue (if applicable): fixes # none

Checklist:

  • [X] The pull request is done against the latest development branch
  • [X] Only relevant files were touched
  • [X] Only one feature/fix was added per PR and the code change compiles without warnings
  • [x] The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • [X] The code change is tested and works with Tasmota core ESP32 V.2.0.3
  • [X] I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

jenicek001 avatar Jun 26 '22 18:06 jenicek001

  • Move template gpios to correct location. Read file header.
  • Learn to use teleperiod. Do NOT program a fixed 60 second interval

arendst avatar Jun 26 '22 18:06 arendst

  • Move template gpios to correct location. Read file header. done
  • Learn to use teleperiod. Do NOT program a fixed 60 second interval done

jenicek001 avatar Jul 06 '22 12:07 jenicek001

Dear maintainers, would somebody please approve my workflow to accept and merge this pull request?

jenicek001 avatar Aug 03 '22 19:08 jenicek001

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 28 '22 20:08 github-actions[bot]

May I do something to support approval and merging of this pull request? Thank you and Best Regards, Jan

jenicek001 avatar Aug 28 '22 21:08 jenicek001

@Cougar May I also ask for your review? After all, it's been here for 16 days… Thank you.

petrkutalek avatar Oct 14 '22 16:10 petrkutalek

I just resolved another conflict with several pull requests added later.

jenicek001 avatar Oct 22 '22 14:10 jenicek001

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 18 '22 19:11 github-actions[bot]

unstale

arendst avatar Nov 19 '22 13:11 arendst

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 14 '22 14:12 github-actions[bot]

bump

arendst avatar Dec 14 '22 14:12 arendst

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jan 13 '23 13:01 github-actions[bot]

Hello, is there some blocking point to merge this pull request?

jenicek001 avatar Feb 04 '23 18:02 jenicek001

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 01 '23 18:03 github-actions[bot]

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 29 '23 09:03 github-actions[bot]

Bump

arendst avatar Mar 29 '23 09:03 arendst

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 10 '23 09:05 github-actions[bot]

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 04 '23 18:06 github-actions[bot]

Hello, is there something I can do to support merge? I successfully use my code on 2 VINDRIKTNINGS for almost 1 year since my pull request, I assume it may be useful to more enthusiasts. Thank you in advance.

jenicek001 avatar Jun 06 '23 19:06 jenicek001

I'm not sure but someone like @s-hadinger can approve or provide some advice on how to merge it.

brozikcz avatar Jun 06 '23 22:06 brozikcz

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 01 '23 22:07 github-actions[bot]

Dear colleagues, does it make sense to delete this working code extension? Did I break some merge rules or what is wrong to merge it? Thank you, Jan

jenicek001 avatar Jul 04 '23 13:07 jenicek001

What is wrong is the fact that non of my initial remarks have been fixed. In addition this is an edge case for some users willing to canibalize their device.

arendst avatar Jul 04 '23 13:07 arendst

Hello Theo, I read your remarks and just few days after I fixed my code to comply with them: https://github.com/arendst/Tasmota/pull/15878#issuecomment-1176156076 Did I miss something important? Regards, Jan

jenicek001 avatar Jul 04 '23 18:07 jenicek001

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 29 '23 18:07 github-actions[bot]

Hello Theo, would you please be more specific what do you mean exactly?

What is wrong is the fact that non of my initial remarks have been fixed. In addition this is an edge case for some users willing to canibalize their device. I did my best to follow your notes since creation of this pull request one year ago, so what should I fix to match with your expectations? Best regards, Jan

jenicek001 avatar Jul 29 '23 19:07 jenicek001

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 23 '23 19:08 github-actions[bot]

This PR was automatically closed because of being stale.

github-actions[bot] avatar Aug 28 '23 19:08 github-actions[bot]