webpack-suit-up icon indicating copy to clipboard operation
webpack-suit-up copied to clipboard

Published 20 hours ago • verified publisher icon areknawo

PWA in cli

Open northkode opened this issue 6 years ago • 4 comments

would be cool if the cli guided the user through PWA support as well

northkode avatar Feb 06 '19 12:02 northkode

As far as I know, Webpack support for PWA can be only done for service worker and manifest file. Are there any more PWA features that could be implemented? If not, it's only a matter of some additional plugins and prompts.

areknawo avatar Feb 06 '19 12:02 areknawo

There are workbox configurations as well as the manifest configs. but that might be out of scope for the CLI, even if it just said, enable PWA true | false and did the imports would be handy.

Also I would recommend doing PWA support for PRODUCTION or UAT webpack configs only so development of the application doesn't install the service worker for each webpack reload. Just a thought.

northkode avatar Feb 06 '19 15:02 northkode

Definitely a good idea. Full PWA CLI support will require some more prompts or it can be left to finish later by the user. I will try to find some free time to do this later, unless you would like to do the PR.

areknawo avatar Feb 06 '19 17:02 areknawo

Sure, I can put a PR together over the weekend.

northkode avatar Feb 07 '19 03:02 northkode