nff-go icon indicating copy to clipboard operation
nff-go copied to clipboard

The packet module should have the ability like here in trex

Open WoolenWang opened this issue 5 years ago • 1 comments

checkout this: https://github.com/cisco-system-traffic-generator/trex-core/tree/master/src/common/Network/Packet

we need some thing like this. now the packet go module is loose and messy. the packet handle ability should separate with different network layer's header.

which will make users like me easy to understand and use it.

WoolenWang avatar Apr 24 '19 10:04 WoolenWang

First of all, this is Go and not C++. All definitions are there in the structs, like IPv4Hdr with corresponding member functions - it was done historically to keep all the core IP stack processing together. There are some discrepancies for sure, but pure design elegance was sacrificed to the ease of use and that is why you are here. Feel free to submit PR that resolves "loose and messy" design.

aregm avatar Apr 24 '19 20:04 aregm