python-sec icon indicating copy to clipboard operation
python-sec copied to clipboard

Filing class edgar_session.make_request method "count" URL parameter is not updated with "number_of_filings" parameter

Open Larkinnjm1 opened this issue 4 years ago • 0 comments

Hey folks,

Happy to look into this optimisation in a pull request if that works for you and if I'm correct in terms of my thinking below.

It looks like in the Filings class the "count" key from self.params dictionary is not updated when a user passes the number_of_filings argument in the get_filings_by_cik method of that class.

As a result the count parameter in the final url get request that is used for the edgar_session.make_request for that method is not updated. Instead the "number_of_filings" is only passed when the returned data from the get request is being parsed.

Hence I am proposing to update that the number_of_filings is passed to update the self.params when the edgar_session.make_request get method is in use as it will specify the number of calls that users wants to perform against the Edgar system for a given filing and mitigate getting locked out too often from Edgar.

Larkinnjm1 avatar Nov 21 '21 22:11 Larkinnjm1