twill icon indicating copy to clipboard operation
twill copied to clipboard
verified publisher icon area17

Implement endpoint params in Browser form field

Open zachgarwood opened this issue 9 months ago • 2 comments

Description

This change completes the partially implemented params option for the Browser form field.

Related Issues

Fixes #2751

zachgarwood avatar Mar 27 '25 22:03 zachgarwood

Hi @zachgarwood, I'm probably missing something as your issue describes the problem well so I'm sure you've experienced it, but the params are already supposed to be added to the endpoint(s( URL server side in the Browser field component class: https://github.com/area17/twill/blob/541a8a7017f302d2024acb0e35cedcab23d31ed1/src/View/Components/Fields/Browser.php#L61 and https://github.com/area17/twill/blob/541a8a7017f302d2024acb0e35cedcab23d31ed1/src/View/Components/Fields/Browser.php#L78

It was working the same way in Twill 2. The logic has just been moved from the blade file to the component class.

ifox avatar Aug 20 '25 01:08 ifox

Ok, I understand the problem now. Because you are passing "raw" endpoints, the lines I linked above do not apply. I think the params could still be appended server side instead of through the vuex state in that case.

ifox avatar Aug 20 '25 02:08 ifox