twill icon indicating copy to clipboard operation
twill copied to clipboard

[4.x] Make laravel-azure-storage a suggested dependency

Open Tofandel opened this issue 1 year ago • 4 comments

Description

matthewbdaly/laravel-azure-storage is present in require of composer but not used anywhere from what I see

It also triggers a warning Package matthewbdaly/laravel-azure-storage is abandoned, you should avoid using it. Use https://github.com/Azure-OSS/azure-storage-php instead.

Tofandel avatar Apr 02 '24 01:04 Tofandel

Hi @Tofandel this dependency is actually used when using azure in MEDIA_LIBRARY_ENDPOINT_TYPE and/or FILE_LIBRARY_ENDPOINT_TYPE.

Unfortunately it looks like efforts to maintain this integration for Laravel have stalled since Microsoft deprecated their SDK.

We could remove the dependency and document installation or even install it dynamically if the azure type is used for now.

ifox avatar May 24 '24 12:05 ifox

Then yes it should be in suggest dependencies and documented in the configuration of MEDIA_LIBRARY_ENDPOINT_TYPE and also using the new recommended lib now, removing it from dependencies now has to be done in v4 though (but changing it to a newer one can be done in v3)

Tofandel avatar May 24 '24 15:05 Tofandel

I agree, but unfortunately the recommended library has no release yet.

ifox avatar May 30 '24 00:05 ifox

The suggestion provided during composer update is Use azure-oss/storage-blob-laravel instead.

kerkness avatar Dec 18 '24 11:12 kerkness